Update aerosol climatology to 2013-2024 mean #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterKolczynski-NOAA
previously approved these changes
Sep 4, 2024
WalterKolczynski-NOAA
added
the
blocked
|
Hold CI testing until #2887 is completed |
|
Is a model update actually required? I don't think the changes here depend on the model regression tests being updated. |
WalterKolczynski-NOAA
changed the title
|
No change of source code in the model needed.
…On Tue, Sep 3, 2024 at 11:06 PM Walter Kolczynski - NOAA < ***@***.***> wrote:
Is a model update actually required? I don't think the changes here depend
on the model regression tests being updated.
—
Reply to this email directly, view it on GitHub
<#2888 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIM4EWMYCRLAE6SJPXDZUZ2L7AVCNFSM6AAAAABNTK4Y7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXHAZDIMZUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
CatherineThomas-NOAA
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Once #2887 is addressed, this PR will need an update to point to the new fix/aer timestamp. Otherwise, looks good.
NeilBarton-NOAA
previously approved these changes
Sep 4, 2024
Good point @WalterKolczynski-NOAA. Thanks. |
CatherineThomas-NOAA
approved these changes
Sep 4, 2024
aerorahul
reviewed
Sep 5, 2024
|
sure. Please make the changes accordingly.
…On Thu, Sep 5, 2024 at 1:42 PM Walter Kolczynski - NOAA < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ush/forecast_predet.sh
<#2888 (comment)>
:
> @@ -498,7 +498,7 @@ FV3_predet(){
local month mm
for (( month = 1; month <=12; month++ )); do
mm=$(printf %02d "${month}")
- ${NCP} "${FIXgfs}/aer/merra2.aerclim.2003-2014.m${mm}.nc" "aeroclim.m${mm}.nc"
+ ${NCP} "${FIXgfs}/aer/merra2_1423_${mm}.nc" "aeroclim.m${mm}.nc"
I took care of the file renaming when staging the new fix files. Just this
line needs to be changed now.
⬇️ Suggested change
- ${NCP} "${FIXgfs}/aer/merra2_1423_${mm}.nc" "aeroclim.m${mm}.nc"
+ ${NCP} "${FIXgfs}/aer/merra2.aerclim.2014-2023.m${mm}.nc" "aeroclim.m${mm}.nc"
—
Reply to this email directly, view it on GitHub
<#2888 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIK72HK3LZLWZMV3YYLZVCJZZAVCNFSM6AAAAABNTK4Y7KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOBTG4YTCNJZG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
WalterKolczynski-NOAA
dismissed stale reviews from NeilBarton-NOAA and themself
via
4b82a06
WalterKolczynski-NOAA
approved these changes
Sep 5, 2024
WalterKolczynski-NOAA
added
CI-Hera-Ready
emcbot
added
CI-Hera-Building
|
CI Passed on Hera in Build# 1 |
WalterKolczynski-NOAA
added
CI-Hercules-Ready
emcbot
added
CI-Hercules-Building
|
emcbot
added
CI-Wcoss2-Running
|
Automated global-workflow Testing Results: |
emcbot
added
CI-Hercules-Running
|
CI Passed on Hercules in Build# 2 |
emcbot
added
CI-Wcoss2-Passed
|
All CI Test Cases Passed on Wcoss2: |
WalterKolczynski-NOAA
merged commit d3ea8e2
into
NOAA-EMC:develop
10 of 11 checks passed
DavidHuber-NOAA
added a commit
to DavidHuber-NOAA/global-workflow
that referenced
this pull request
Sep 9, 2024
* origin/develop: Create JEDI class (NOAA-EMC#2805) Restructure the bufr sounding job (NOAA-EMC#2853) Add an archive task to GEFS system to archive files locally (NOAA-EMC#2816) Reenable Orion Cycling Support (NOAA-EMC#2877) Eliminate race conditions and remove DATAROOT last in cleanup (NOAA-EMC#2893) Update aerosol climatology to 2013-2024 mean (NOAA-EMC#2888) Add ability to run CI test C96_atm3DVar.yaml to Gaea-C5 (NOAA-EMC#2885) Support global-workflow GEFS C48 on Google Cloud (NOAA-EMC#2861) Add 3 and 9 hr increment files to IC staging (NOAA-EMC#2876) Add diffusion/diag B for aerosol DA and some other needed changes (NOAA-EMC#2738) Correct ocean `MOM.res_#` stage copy (NOAA-EMC#2868) Support coupling on AWS (NOAA-EMC#2859) Add JEDI ATM lgetkf observer and solver jobs (NOAA-EMC#2833) Fix gdas build on Gaea and add Gaea to available CI list (NOAA-EMC#2857) Support ATM forecast only on Google (NOAA-EMC#2832) Add GEFS C48 support on AWS (NOAA-EMC#2818) Update omega calculation (NOAA-EMC#2751) Add snow DA update and recentering for the EnKF forecasts (NOAA-EMC#2690) support ATM forecast only on Azure (NOAA-EMC#2827) Convert staging job to python and yaml (NOAA-EMC#2651) Fixed test on UNAVAILBLE in python Rocoto check (NOAA-EMC#2842)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use the updated 2013 to 2024 mean MERRA2 climatology instead of 2003 to 2014 mean
Depends on #2887
Refs: ufs-community/ufs-weather-model#2272
Refs: ufs-community/ufs-weather-model#2273
Type of change
Change characteristics
How has this been tested?
Checklist